fix: Use require instead of require_relative to load extension#366
Open
dividedmind wants to merge 1 commit intomasterfrom
Open
fix: Use require instead of require_relative to load extension#366dividedmind wants to merge 1 commit intomasterfrom
dividedmind wants to merge 1 commit intomasterfrom
Conversation
In some environments, `gem install` places the extension .so in a separate directory tree than Ruby code, which makes it unfindable with `require_relative`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
lib/appmap/agent.rbfile to improve the loading of required files and handle potential directory differences for theappmapextension.File loading improvements:
lib/appmap/agent.rb: Changed therequire_relative "appmap"statement torequire "appmap/appmap"to handle cases where theappmapextension might not be in the same directory.